fix: prevent collector subprocess from deadlocking on full pipe buffer
Collector was spawned with stdout=PIPE but nobody read from the pipe. After days of accumulated log output the OS buffer filled, blocking the collector and freezing all metrics updates.
This commit is contained in:
parent
0babff823a
commit
cca49ca2cf
1 changed files with 2 additions and 2 deletions
|
|
@ -92,8 +92,8 @@ def _start_collector() -> None:
|
||||||
global _collector_proc
|
global _collector_proc
|
||||||
_collector_proc = subprocess.Popen(
|
_collector_proc = subprocess.Popen(
|
||||||
[sys.executable, "-m", "wiregui.collector"],
|
[sys.executable, "-m", "wiregui.collector"],
|
||||||
stdout=subprocess.PIPE,
|
stdout=subprocess.DEVNULL,
|
||||||
stderr=subprocess.STDOUT,
|
stderr=subprocess.DEVNULL,
|
||||||
)
|
)
|
||||||
logger.info("Metrics collector started (pid={})", _collector_proc.pid)
|
logger.info("Metrics collector started (pid={})", _collector_proc.pid)
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue