From 70eb9f6b1216dc630c8af6c48d5f851297cf6f0f Mon Sep 17 00:00:00 2001
From: Stefano Bertelli <stefano@provvedo.com>
Date: Tue, 31 Mar 2026 17:02:49 -0500
Subject: [PATCH] fix: run migrations before unit tests in CI

Some unit tests (test_api_deps, test_server_key) are integration tests
that need DB tables. Move alembic upgrade head before unit tests.
---
 .forgejo/workflows/dev.yml     |  7 ++--
 .forgejo/workflows/release.yml |  7 ++--
 tests/test_server_key.py       | 63 ++++++++++++++++++++++++++++++++++
 3 files changed, 71 insertions(+), 6 deletions(-)
 create mode 100644 tests/test_server_key.py

diff --git a/.forgejo/workflows/dev.yml b/.forgejo/workflows/dev.yml
index 86a030f..d9af59c 100644
--- a/.forgejo/workflows/dev.yml
+++ b/.forgejo/workflows/dev.yml
@@ -62,13 +62,14 @@ jobs:
       - name: Install Playwright browsers
         run: uv run playwright install --with-deps chromium
 
+      - name: Run migrations
+        run: uv run alembic upgrade head
+
       - name: Run unit tests
         run: uv run pytest tests/ --ignore=tests/e2e -v --tb=short
 
       - name: Run E2E tests
-        run: |
-          uv run alembic upgrade head
-          uv run pytest tests/e2e/ -v --tb=short
+        run: uv run pytest tests/e2e/ -v --tb=short
 
   docker:
     needs: test
diff --git a/.forgejo/workflows/release.yml b/.forgejo/workflows/release.yml
index 263e1ae..ef5d4e4 100644
--- a/.forgejo/workflows/release.yml
+++ b/.forgejo/workflows/release.yml
@@ -63,13 +63,14 @@ jobs:
       - name: Install Playwright browsers
         run: uv run playwright install --with-deps chromium
 
+      - name: Run migrations
+        run: uv run alembic upgrade head
+
       - name: Run unit tests
         run: uv run pytest tests/ --ignore=tests/e2e -v --tb=short
 
       - name: Run E2E tests
-        run: |
-          uv run alembic upgrade head
-          uv run pytest tests/e2e/ -v --tb=short
+        run: uv run pytest tests/e2e/ -v --tb=short
 
   release:
     needs: test
diff --git a/tests/test_server_key.py b/tests/test_server_key.py
new file mode 100644
index 0000000..b325d45
--- /dev/null
+++ b/tests/test_server_key.py
@@ -0,0 +1,63 @@
+"""Tests for server public key retrieval from Configuration table."""
+
+import pytest
+
+from wiregui.db import async_session
+from wiregui.models.configuration import Configuration
+from wiregui.utils.server_key import get_server_public_key
+from sqlmodel import select
+
+
+@pytest.fixture(autouse=True)
+async def _snapshot_config():
+    """Snapshot and restore server_public_key around each test."""
+    async with async_session() as session:
+        c = (await session.execute(select(Configuration).limit(1))).scalar_one_or_none()
+        orig = c.server_public_key if c else None
+        cid = c.id if c else None
+
+    yield
+
+    if cid:
+        async with async_session() as session:
+            c = await session.get(Configuration, cid)
+            if c:
+                c.server_public_key = orig
+                session.add(c)
+                await session.commit()
+
+
+async def test_get_server_public_key_returns_key():
+    """Returns the public key when configured."""
+    async with async_session() as session:
+        c = (await session.execute(select(Configuration).limit(1))).scalar_one_or_none()
+        c.server_public_key = "TestServerPubKey123456789012345678901234w="
+        session.add(c)
+        await session.commit()
+
+    result = await get_server_public_key()
+    assert result == "TestServerPubKey123456789012345678901234w="
+
+
+async def test_get_server_public_key_raises_when_missing():
+    """Raises RuntimeError when server_public_key is None."""
+    async with async_session() as session:
+        c = (await session.execute(select(Configuration).limit(1))).scalar_one_or_none()
+        c.server_public_key = None
+        session.add(c)
+        await session.commit()
+
+    with pytest.raises(RuntimeError, match="not configured"):
+        await get_server_public_key()
+
+
+async def test_get_server_public_key_raises_when_empty_string():
+    """Raises RuntimeError when server_public_key is empty string."""
+    async with async_session() as session:
+        c = (await session.execute(select(Configuration).limit(1))).scalar_one_or_none()
+        c.server_public_key = ""
+        session.add(c)
+        await session.commit()
+
+    with pytest.raises(RuntimeError, match="not configured"):
+        await get_server_public_key()
\ No newline at end of file